Fix silenced guns not shooting silently #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jomosoto
requested changes
Apr 6, 2023
Member
There was a problem hiding this comment.
FlansMod/src/main/java/com/flansmod/common/network/PacketPlaySound.java
Lines 103 to 108 in d273da7
I would decrease the volume a lot more here. I found that 0.5F sounds good. With the current 2F you hear almost no difference.
FMLClientHandler.instance().getClient().getSoundHandler().playSound(
new PositionedSoundRecord(event,
SoundCategory.PLAYERS,
- silenced ? 2F : 4F,
+ silenced ? 0.5F : 4F,
(distort ? 1.0F / (rand.nextFloat() * 0.4F + 0.8F) : 1.0F) * (silenced ? 2F : 1F),
posX, posY, posZ));
Author
|
I changed as suggested. Sounds much better indeed. |
Member
|
Sounds good 👍 |
Member
|
I tested it in multiplayer. The volume is good, when you stand next to the person, but it's dropping really quickly with the distance and at about 15 blocks it's completely silent. Could you please look if it's possible to keep the volume, but increase the range |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Silencers on guns didn't work because of the boolean "silenced" being used as wrong parameter in method.
Now they do.